Return-path: Received: from mail-lf0-f48.google.com ([209.85.215.48]:33147 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbcCSIWO (ORCPT ); Sat, 19 Mar 2016 04:22:14 -0400 Received: by mail-lf0-f48.google.com with SMTP id h198so79697401lfh.0 for ; Sat, 19 Mar 2016 01:22:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160319080627.GA29771@redhat.com> References: <1458318591-14921-1-git-send-email-vishalthanki@gmail.com> <20160319080627.GA29771@redhat.com> From: Vishal Thanki Date: Sat, 19 Mar 2016 09:21:52 +0100 Message-ID: (sfid-20160319_092224_726776_A9045468) Subject: Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB To: Stanislaw Gruszka Cc: Helmut Schaa , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka wrote: > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: >> >> @@ -1001,6 +1002,9 @@ struct rt2x00_dev { >> >> /* Extra TX headroom required for alignment purposes. */ >> unsigned int extra_tx_headroom; >> + >> + struct usb_anchor *anchor; >> + void (*kill_anchored_urbs)(struct rt2x00_dev *); > ... >> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev) >> cancel_delayed_work_sync(&rt2x00dev->autowakeup_work); >> cancel_work_sync(&rt2x00dev->sleep_work); >> if (rt2x00_is_usb(rt2x00dev)) { >> + rt2x00dev->kill_anchored_urbs(rt2x00dev); > ... >> >> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev) >> +{ >> + usb_kill_anchored_urbs(rt2x00dev->anchor); >> +} > ... >> + rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb; > > Why do you complicate things, instead of call usb_kill_anchored_urbs() > directly? > I tried to compile by disabling the CONFIG_USB from kernel, and was getting error for missing symbol usb_kill_anchored_urbs. > Stanislaw