Message-ID: <1457019447.2044.24.camel@sipsolutions.net> (sfid-20160303_163735_151313_71D1FAD1)
Subject: Re: [PATCH v2 1/2] mac80211: add A-MSDU tx support
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>, linux-wireless@vger.kernel.org
Cc: egrumbach@gmail.com
Date: Thu, 03 Mar 2016 16:37:27 +0100
In-Reply-To: <56D85428.6090705@openwrt.org>
References: <1456306140-78485-1-git-send-email-nbd@openwrt.org>
	 <1457016860.2044.11.camel@sipsolutions.net> <56D85428.6090705@openwrt.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Thu, 2016-03-03 at 16:11 +0100, Felix Fietkau wrote:
> 
> For my own uses, I'd be perfectly fine with limiting A-MSDU size to
> HT limits even when using VHT - in fact I did that in an early RFC
> patch. I mainly relaxed the limit for VHT based on Emmanuel's
> feedback. I also have doubts about the value of A-MSDU size beyond
> 4095 bytes.
> 
> Just let me know which way you'd like it, and I'll send v3
> accordingly.
> 

I don't really know, I can live with both ways. I'm just a bit worried
that we make enabling this feature so complex that nobody will get it
right.

Perhaps we could also just remove this, make the default
for max_rc_amsdu_len be 4095 (or so) and leave the rest to the rate
control? We could entirely remove this check here, and let minstrel
only use higher values if VHT is supported (and consequently will be
used)?

johannes