Reply-To: arend@broadcom.com
Subject: Re: [PATCH V11 1/2] nl80211: add feature for BSS selection support
References: <1456947439-28968-1-git-send-email-arend@broadcom.com>
 <1457020529.2044.31.camel@sipsolutions.net>
To: Johannes Berg <johannes@sipsolutions.net>,
	Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <56D88E44.5080705@broadcom.com> (sfid-20160303_201940_872553_4D04CC66)
Date: Thu, 3 Mar 2016 20:19:32 +0100
MIME-Version: 1.0
In-Reply-To: <1457020529.2044.31.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org


On 3-3-2016 16:55, Johannes Berg wrote:
> On Wed, 2016-03-02 at 20:37 +0100, Arend van Spriel wrote:
>> Introducing a new feature that the driver can use to
>> indicate the driver/firmware supports configuration of BSS
>> selection criteria upon CONNECT command. This can be useful
>> when multiple BSS-es are found belonging to the same ESS,
>> ie. Infra-BSS with same SSID. The criteria can then be used to
>> offload selection of a preferred BSS.
>>
> Applied, finally :)

Yeah. I was afraid it would not make it in 4.6.

> I moved the wiphy supported methods check into parse_bss_select() to
> avoid the double error path in the caller, plus some editorial changes.

Looking at it

+       /* user-space did not provide behaviour attribute */
+       if (bss_select->behaviour == __NL80211_BSS_SELECT_ATTR_INVALID)
+               return -EINVAL;
+
+       if (!(wiphy->bss_select_support & BIT(bss_select->behaviour)))
+               return -EINVAL;

the first check is (and already was) redundant.

Regards,
Arend