Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50408 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcCGMZ6 (ORCPT ); Mon, 7 Mar 2016 07:25:58 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient From: Kalle Valo In-Reply-To: <1456140946-12509-1-git-send-email-colin.king@canonical.com> To: Colin Ian King Cc: Larry Finger , Chaoming Li , Priit Laes , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20160307122556.D5EFC6060D@smtp.codeaurora.org> (sfid-20160307_132606_942369_48589645) Date: Mon, 7 Mar 2016 12:25:56 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a relatively large overhead. > This change just affects just the rx_command_packet calls. > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Thanks, applied to wireless-drivers-next.git. Kalle Valo