Return-path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:35310 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcCRDc2 (ORCPT ); Thu, 17 Mar 2016 23:32:28 -0400 Received: by mail-oi0-f50.google.com with SMTP id w20so23366852oia.2 for ; Thu, 17 Mar 2016 20:32:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <56EB6A10.5030900@lwfinger.net> References: <56EB6A10.5030900@lwfinger.net> From: Julian Calaby Date: Fri, 18 Mar 2016 14:32:07 +1100 Message-ID: (sfid-20160318_043231_717066_5C3B0DDA) Subject: Re: [PATCH MOREWORK 16/19] rtlwifi: Implement 'rtl_addr_delay()' with a switch statement To: Larry Finger Cc: Kalle Valo , Chaoming Li , Johannes Berg , Byeoungwook Kim , Markus Elfring , Sara Sharon , Emmanuel Grumbach , Luis Felipe Dominguez Vega , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Larry, On Fri, Mar 18, 2016 at 1:38 PM, Larry Finger wrote: > On 03/17/2016 09:28 PM, Julian Calaby wrote: >> >> From: Byeoungwook Kim >> >> Doing it this way improves readability. >> >> Signed-off-by: Byeoungwook Kim >> [Rewrote commit message] >> Signed-off-by: Julian Calaby >> >> --- >> >> ... or does it. >> >> Honesltly, this is only in this list as Byeoungwook asked about it and I >> can see _some_ sort of reason why it exists. >> >> Larry, if you don't like this, please NACK it and we'll never speak of it >> again. >> >> Thanks, >> >> Julian Calaby >> --- >> drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++++++++++++++------ >> 1 file changed, 14 insertions(+), 6 deletions(-) > > > I thought I had already NACKed it, but just in case: > > NACK. Consider it dropped. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/