Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52696 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966998AbcCQLUt (ORCPT ); Thu, 17 Mar 2016 07:20:49 -0400 Date: Thu, 17 Mar 2016 16:50:34 +0530 From: Mohammed Shafi Shajakhan To: Michal Kazior Cc: Mohammed Shafi Shajakhan , "ath10k@lists.infradead.org" , Kalle Valo , "kvalo@codeaurora.org" , linux-wireless Subject: Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support Message-ID: <20160317112022.GA27512@atheros-ThinkPad-T61> (sfid-20160317_122055_442606_DC54752A) References: <1458211740-6875-1-git-send-email-mohammed@qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Michal, On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: > On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan > wrote: > [...] > > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif *vif, > > + struct ieee80211_sta *sta, > > + struct station_info *sinfo) > > +{ > > + struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv; > > + struct ath10k *ar = arsta->arvif->ar; > > + > > + mutex_lock(&ar->conf_mutex); > > + > > + if (ar->state != ATH10K_STATE_ON && > > + ar->state != ATH10K_STATE_RESTARTED) > > + goto out; > > Do you really need mutex and ar->state check in this function? > [shafi] By default peer stats will be disabled, we are enabling this by debugfs (hw-restart) so i thought these checks are needed , please advise .. Do you say they will be never hit regards shafi