Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:35222 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbcCRKmp (ORCPT ); Fri, 18 Mar 2016 06:42:45 -0400 Received: by mail-ob0-f170.google.com with SMTP id fp4so111805099obb.2 for ; Fri, 18 Mar 2016 03:42:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160318103124.GC24990@redhat.com> References: <90fe6325e407d35a18fa8c8cb7eaa269968d6426.1458262312.git.julian.calaby@gmail.com> <20160318103124.GC24990@redhat.com> From: Julian Calaby Date: Fri, 18 Mar 2016 21:42:25 +1100 Message-ID: (sfid-20160318_114250_625741_FF1F85B6) Subject: Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init() To: Stanislaw Gruszka Cc: Kalle Valo , Markus Elfring , Nicolas Pitre , Dan Carpenter , Jia-Ju Bai , Arnd Bergmann , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Stanislaw, On Fri, Mar 18, 2016 at 9:31 PM, Stanislaw Gruszka wrote: > On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: >> From: Markus Elfring >> >> Rename a jump label according to the current Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> [Rewrote commit title] >> Signed-off-by: Julian Calaby >> >> --- >> >> This was controversial when introduced, however the change is obvious and >> harmless and is, in the worst case, just churn. >> >> I'm only including this as it meets my criteria for sheparding pending >> patches: it's sane, obviously correct or reviewable by me, and doesn't >> require any work to apply. >> >> This does meet those requirements, however given how controviersial it was >> when introduced, I'm not expecting people to be enthusiastic about >> applying it. > > I don't see the sense of that change, NACK Fair enough, I wasn't expecting this to get applied anyway. Consider it dropped. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/