Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:40910 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752237AbcDUPPH (ORCPT ); Thu, 21 Apr 2016 11:15:07 -0400 Subject: Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz To: Kalle Valo , ath10k@lists.infradead.org References: <1461244669-19871-1-git-send-email-kvalo@qca.qualcomm.com> Cc: linux-wireless@vger.kernel.org From: Ben Greear Message-ID: <5718EE7A.4030503@candelatech.com> (sfid-20160421_171514_734039_B1F3CF8F) Date: Thu, 21 Apr 2016 08:15:06 -0700 MIME-Version: 1.0 In-Reply-To: <1461244669-19871-1-git-send-email-kvalo@qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/21/2016 06:17 AM, Kalle Valo wrote: > From: Johannes Berg > > According to the spec, VHT doesn't exist in 2.4GHz. > > There are vendor extensions to allow a subset of VHT to work > (notably 256-QAM), but since mac80211 doesn't support those > advertising VHT capability on 2.4GHz leads to the behaviour > of reporting VHT capabilities but not being able to use any > of them due to mac80211's code requiring 80 MHz support. > > Remove the VHT capabilities from 2.4GHz for now. If mac80211 > gets extended to use the (likely Broadcom) vendor IEs for it > and handles the lack of 80 MHz support, it can be added back. > > Signed-off-by: Johannes Berg > Signed-off-by: Kalle Valo The thing is, it actually works just fine with the patch I posted to fix mac80211, and at any rate, even if the mac80211 patch isn't applied, the ath10k driver works just fine in HT mode. Have you actually found any case where the existing behaviour causes a real problem? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com