Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:37800 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752935AbcDAOE1 (ORCPT ); Fri, 1 Apr 2016 10:04:27 -0400 Message-ID: <56FE7FEA.5090708@candelatech.com> (sfid-20160401_160440_446838_581D5FE1) Date: Fri, 01 Apr 2016 07:04:26 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH 3/3] ath10k: Add BUG_ON if we over-write peer-map pointer. References: <1459457986-29222-1-git-send-email-greearb@candelatech.com> <1459457986-29222-3-git-send-email-greearb@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/31/2016 11:09 PM, Michal Kazior wrote: > On 31 March 2016 at 22:59, wrote: >> From: Ben Greear >> >> Not sure this can happen, but seems like a reasonable sanity >> check. >> >> Signed-off-by: Ben Greear >> --- >> drivers/net/wireless/ath/ath10k/txrx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c >> index 94c27f6..172b1d6 100644 >> --- a/drivers/net/wireless/ath/ath10k/txrx.c >> +++ b/drivers/net/wireless/ath/ath10k/txrx.c >> @@ -309,6 +309,7 @@ void ath10k_peer_map_event(struct ath10k_htt *htt, >> ath10k_warn(ar, /*ATH10K_DBG_HTT,*/ "htt peer map vdev %d peer %pM id %d\n", >> ev->vdev_id, ev->addr, ev->peer_id); >> >> + BUG_ON(ar->peer_map[ev->peer_id] && (ar->peer_map[ev->peer_id] != peer)); > > Does this really need to be a BUG_ON? It means we have memory or logic corruption, or maybe we are out of sync with the firmware, so I think it should be very visible, at least for a while. I haven't hit it, so not sure it can happen anyway.... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com