Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56169 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754481AbcDSOtL (ORCPT ); Tue, 19 Apr 2016 10:49:11 -0400 From: Jes Sorensen To: Arnd Bergmann Cc: Kalle Valo , Jakub Sitnicki , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtl8xxxu: hide unused tables References: <1461016782-2640046-1-git-send-email-arnd@arndb.de> Date: Tue, 19 Apr 2016 10:49:08 -0400 In-Reply-To: <1461016782-2640046-1-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Apr 2016 23:59:31 +0200") Message-ID: (sfid-20160419_164935_250964_8F612606) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > The references to some arrays in the rtl8xxxu driver were moved inside > of an #ifdef, but the symbols remain outside, resulting in build warnings: > > rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' defined but not used > rtl8xxxu/rtl8xxxu.c:1431:33: error: 'rtl8192cu_radioa_1t_init_table' defined but not used > rtl8xxxu/rtl8xxxu.c:1407:33: error: 'rtl8192cu_radiob_2t_init_table' defined but not used > rtl8xxxu/rtl8xxxu.c:1332:33: error: 'rtl8192cu_radioa_2t_init_table' defined but not used > rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used > rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used > > This adds an extra #ifdef around them to shut up the warnings. > > Signed-off-by: Arnd Bergmann > Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") > Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific functions") > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++++ > 1 file changed, 4 insertions(+) I'll apply it to my tree! Thanks, Jes