Return-path: Received: from mail-io0-f173.google.com ([209.85.223.173]:33764 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbcDPIPZ (ORCPT ); Sat, 16 Apr 2016 04:15:25 -0400 Received: by mail-io0-f173.google.com with SMTP id o126so155386638iod.0 for ; Sat, 16 Apr 2016 01:15:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1460367328-12082-4-git-send-email-arend@broadcom.com> References: <1460367328-12082-1-git-send-email-arend@broadcom.com> <1460367328-12082-4-git-send-email-arend@broadcom.com> Date: Sat, 16 Apr 2016 10:15:24 +0200 Message-ID: (sfid-20160416_101534_469709_783B3989) Subject: Re: [PATCH 3/8] brcmfmac: insert default boardrev in nvram data if missing From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: Kalle Valo , linux-wireless , Hante Meuleman Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11 April 2016 at 11:35, Arend van Spriel wrote: > From: Hante Meuleman > > Some nvram files/stores come without the boardrev information, > but firmware requires this to be set. When not found in nvram then > add a default boardrev string to the nvram data. > > Reported-by: Rafal Milecki > Reviewed-by: Arend Van Spriel > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Hante Meuleman > Signed-off-by: Arend van Spriel I needed to wait for a weekend to give it a try. It fixed my problem, nice work, thanks! Tested-by: Rafal Milecki