Return-path: Received: from mail-yw0-f170.google.com ([209.85.161.170]:34315 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbcEDGig (ORCPT ); Wed, 4 May 2016 02:38:36 -0400 Received: by mail-yw0-f170.google.com with SMTP id j74so60859023ywg.1 for ; Tue, 03 May 2016 23:38:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1462305820.10444.14.camel@sipsolutions.net> References: <1462281243.2251.2.camel@sipsolutions.net> <1462291262.2251.4.camel@sipsolutions.net> <1462304144.10444.13.camel@sipsolutions.net> <1462305820.10444.14.camel@sipsolutions.net> From: Krishna Chaitanya Date: Wed, 4 May 2016 12:08:16 +0530 Message-ID: (sfid-20160504_083840_225775_B0860FA1) Subject: Re: dynamic ps + offchannel mgmt_tx + HW RoC To: Johannes Berg Cc: Janusz Dziedzic , linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, May 4, 2016 at 1:33 AM, Johannes Berg wrote: > On Wed, 2016-05-04 at 01:20 +0530, Krishna Chaitanya wrote: >> On Wed, May 4, 2016 at 1:05 AM, Johannes Berg > net> wrote: >> > >> > There is, btw, perhaps a different way - just fix the damn stuff. >> > >> > Requires moving everything into ifmgd rather than local, and then >> > perhaps if only a single managed interface exists mirroring its >> > state >> > into the existing driver calls etc. >> > >> > It'd still be a big task, and I don't see much advantage over just >> > reimplementing it. >> Yes, requires quite an effort and also need to handle lot of cases. >> Instead, why don't we make the default as complete PS offload >> and force the drivers who need to use mac80211 PS negate these >> in the register_hw? That way we are clear about the intentions. > > I don't really see a big advantage, and it'd create churn in a lot of > drivers. Maybe documenting it with the flags that we really think you > should set them or something, or making the powersave DOC section > mention this would be good, but beyond that I don't think it'd be a > good idea. that's fine with me.