Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:33673 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932813AbcEXRxu (ORCPT ); Tue, 24 May 2016 13:53:50 -0400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: ath10k: Reduce warning messages during rx without proper channel context From: Kalle Valo In-Reply-To: <1462893136-16051-1-git-send-email-mohammed@qca.qualcomm.com> To: Mohammed Shafi Shajakhan CC: , , , Mohammed Shafi Shajakhan Message-ID: <2a006d27321a4a0390253ca9e1c47348@euamsexm01a.eu.qualcomm.com> (sfid-20160524_195356_836070_A3F7FD8F) Date: Tue, 24 May 2016 19:53:43 +0200 Sender: linux-wireless-owner@vger.kernel.org List-ID: Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > WARN_ON_ONCE when we receive packets for self peer when mac80211 > had not assigned a proper channel context. This scenario happens > in QCA4019 when we start the AP via hostapd in background and start > it once again in the background without killing the previous instance! > This happens intermittently when we start / stop hostapd in a while loop > (incase the hostapd is not properly killed). This results in mac80211 > chancontext to be unassigned, while the self peer continuous receive > packets in target operating channel. This results in lot of call traces > in the rx path. Make this as a WARN_ON_ONCE to avoid flooding the console > which result in rebooting low memory systems, while still reporting the > warning once that we are receiving packets in target operating channel and > to indicate that something is happening which is not the expected result. > > WARNING: CPU: 0 PID: 0 at ath/ath10k/htt_rx.c:803 > [] (warn_slowpath_null) from [] > (ath10k_htt_rx_h_channel+0xe0/0x1b8 [ath10k_core]) > [] (ath10k_htt_rx_h_channel [ath10k_core]) from > [] (ath10k_htt_rx_h_ppdu+0x80/0x288 [ath10k_core]) > [] (ath10k_htt_rx_h_ppdu [ath10k_core]) from > [] (ath10k_htt_txrx_compl_task+0x724/0x9d4 [ath10k_core]) > [] (ath10k_htt_txrx_compl_task [ath10k_core]) > > Signed-off-by: Mohammed Shafi Shajakhan Thanks, 1 patch applied to ath.git: 3b0499e9ce42 ath10k: reduce warning messages during rx without proper channel context -- Sent by pwcli https://patchwork.kernel.org/patch/9058791/