Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:51698 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbcEKPKL (ORCPT ); Wed, 11 May 2016 11:10:11 -0400 Message-ID: <57334B51.1010104@candelatech.com> (sfid-20160511_171028_297431_072D8790) Date: Wed, 11 May 2016 08:10:09 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH 03/21] ath10k: Support setting debug mask from driver code. References: <1462835475-11079-1-git-send-email-greearb@candelatech.com> <1462835475-11079-4-git-send-email-greearb@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/11/2016 03:40 AM, Michal Kazior wrote: > On 10 May 2016 at 01:10, wrote: >> From: Ben Greear >> >> Might want to turn off verbose debug as soon as you >> see a firmware crash, for instance. Helps keep dmesg >> output from over-running the stuff you care about. >> >> Signed-off-by: Ben Greear >> --- >> drivers/net/wireless/ath/ath10k/debug.c | 5 +++++ >> drivers/net/wireless/ath/ath10k/debug.h | 1 + >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c >> index e251155..a689bf1 100644 >> --- a/drivers/net/wireless/ath/ath10k/debug.c >> +++ b/drivers/net/wireless/ath/ath10k/debug.c >> @@ -194,6 +194,11 @@ void ath10k_print_driver_info(struct ath10k *ar) >> } >> EXPORT_SYMBOL(ath10k_print_driver_info); >> >> +void ath10k_set_debug_mask(unsigned int v) { > > The { should be on new line. > > >> + ath10k_debug_mask = v; >> +} >> +EXPORT_SYMBOL(ath10k_set_debug_mask); > > I didn't see any uses of this in your patchset (it's commented out in > 21/21) and I'm not fully convinced it's a good idea to override > debug_mask like that. Once I set a debug_mask I expect it to stay > unchanged. What if I do want to trace what happens after fw crash? > > Wouldn't it be better to have a knob to tell ath10k whether hw > recovery should be automatic or manual? Hmm, I have a later patch that allows twiddling this through debugfs, that is what I meant to add to this series. I'll find that one and squash it into this one. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com