Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:36372 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbcERBU1 (ORCPT ); Tue, 17 May 2016 21:20:27 -0400 Received: by mail-oi0-f66.google.com with SMTP id i2so6824430oib.3 for ; Tue, 17 May 2016 18:20:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1463534086-22353-2-git-send-email-dlenski@gmail.com> References: <1463534086-22353-1-git-send-email-dlenski@gmail.com> <1463534086-22353-2-git-send-email-dlenski@gmail.com> From: Julian Calaby Date: Wed, 18 May 2016 11:20:07 +1000 Message-ID: (sfid-20160518_032031_330995_EBD48430) Subject: Re: [PATCH 1/2] rtl8xxxu: Increase default polling timeout for firmware startup To: Dan Lenski Cc: linux-wireless , Jes Sorensen Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On Wed, May 18, 2016 at 11:14 AM, Dan Lenski wrote: > This patch increases the default value for the maximum number of polling > loops to wait for the rtl8xxxu MCU to start after the firmware is loaded > (from 1000 to 5000). > > With RTL8723AU chipset, I frequently encounter "Firmware failed to start" > errors from rtl8xxxu after a cold boot. > > It appears that other chipsets supported by the driver have the same > problem. Here are a couple of relevant bug reports: > - http://ubuntuforums.org/showthread.php?t=2321756 > - https://www.mail-archive.com/ubuntu-bugs@lists.ubuntu.com/msg4942468.html > > This issue seems to occur because RTL8XXXU_FIRMWARE_POLL_MAX (1000) is > too short, and the MCU fails to start up as quickly as expected. > > With a longer value (5000), the driver starts up consistently and > successfully after cold-boot. > > Signed-off-by: Dan Lenski This looks good to me. Reviewed-by: Julian Calaby > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > index f2a1bac..39c6ce7 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > @@ -49,7 +49,7 @@ > #define TX_PAGE_NUM_NORM_PQ 0x02 > > #define RTL_FW_PAGE_SIZE 4096 > -#define RTL8XXXU_FIRMWARE_POLL_MAX 1000 > +#define RTL8XXXU_FIRMWARE_POLL_MAX 5000 > > #define RTL8723A_CHANNEL_GROUPS 3 > #define RTL8723A_MAX_RF_PATHS 2 > -- > 2.8.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/