Return-path: Received: from mail-wm0-f53.google.com ([74.125.82.53]:38369 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758143AbcEFP5c (ORCPT ); Fri, 6 May 2016 11:57:32 -0400 Received: by mail-wm0-f53.google.com with SMTP id g17so84945403wme.1 for ; Fri, 06 May 2016 08:57:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87wpn7p6dv.fsf@kamboji.qca.qualcomm.com> References: <1462280620-13000-1-git-send-email-jjmeijer88@gmail.com> <87poszs8tc.fsf@kamboji.qca.qualcomm.com> <87wpn7p6dv.fsf@kamboji.qca.qualcomm.com> From: Jaap Jan Meijer Date: Fri, 6 May 2016 16:57:11 +0100 Message-ID: (sfid-20160506_175735_572312_982B14B3) Subject: Re: [PATCH] Fix regression in Android due to rework .get_station() callback To: Kalle Valo Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2016-05-06 16:12 GMT+01:00 Kalle Valo : > Jaap Jan Meijer writes: > >> Hi Kalle, >> >> Op vr 6 mei 2016 12:52 schreef Kalle Valo : >> >> >> This has multiple issues: >> >> o Use your full name. >> o Use prefix "brcmfmac: " in the title. >> >> o I can't find commit f654d13, is the commit id really correct? >> o Also check from SubmittingPatches how you should reference commit ids. >> >> >> >> Thank you for the feedback, I will send a reworked patch as soon as I get home >> next week. Also I did this against v4.4.8 so I'll have to rebase it as well. >> >> I'm not sure what went wrong with the commit hash, its actually this commit: >> 1f0dc59a6de93586fcfc04696a61946408ffc56a. > > That commit id looks to be valid. > >> I see you did this commit, maybe you can check if this actually is the root >> cause? I'm sure you have a lot more insight into this issue than I do. > > Please CC the list so that everyone can join the discussion. > > -- > Kalle Valo Sorry, I shouldn't do this on a mobile device.