Return-path: Received: from mail-yw0-f171.google.com ([209.85.161.171]:35565 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932867AbcECOca (ORCPT ); Tue, 3 May 2016 10:32:30 -0400 Received: by mail-yw0-f171.google.com with SMTP id g133so19788973ywb.2 for ; Tue, 03 May 2016 07:32:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1462281243.2251.2.camel@sipsolutions.net> From: Krishna Chaitanya Date: Tue, 3 May 2016 20:02:10 +0530 Message-ID: (sfid-20160503_163248_426189_920A5E4F) Subject: Re: dynamic ps + offchannel mgmt_tx + HW RoC To: Johannes Berg Cc: linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 3, 2016 at 7:46 PM, Krishna Chaitanya wrote: > On Tue, May 3, 2016 at 6:44 PM, Johannes Berg wrote: >> On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote: >>> Hi, >>> >>> When the HW is in PS and Dynamic PS is enabled we are dropping >>> all the offchannel frames. Sequence is as below >>> >>> if hw is in PS: stop_queues reason=PS, queue dynamic_ps_disable_work >>> send Offchannel mgmt_tx >>> drop the packet because offchanel + stop_reasons[q] !=0 >>> >>> How should we handle this? SW RoC is handling this >>> by checking for offchannel and bringing the HW out of PS before >>> handing the packet to TX path, so it works fine. >> >> You should handle this by not doing such a non-sensical thing and >> finally implementing powersave properly in the driver :) > i don't see any issues in the powersave w.r.t driver. Isn't it a > valid case? you meant implementing dynamic_ps? If it advertise HW_SUPPORTS_DYNAMIC_PS it works fine. so may be we should queue those frames and send it to HW once it is out of powersave?