Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:39797 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755867AbcEFSKH convert rfc822-to-8bit (ORCPT ); Fri, 6 May 2016 14:10:07 -0400 From: "Valo, Kalle" To: "Kolli, Anilkumar" CC: "ath10k@lists.infradead.org" , "akolli@codeaurora.org" , "linux-wireless@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] ath10k: fix kernel panic, move arvifs list head init before htt init Date: Fri, 6 May 2016 18:09:58 +0000 Message-ID: <87a8k3njm2.fsf@kamboji.qca.qualcomm.com> (sfid-20160506_201016_726410_551D8812) References: <1461686748-862-1-git-send-email-akolli@qti.qualcomm.com> In-Reply-To: <1461686748-862-1-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Tue, 26 Apr 2016 21:35:48 +0530") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: writes: > From: Anilkumar Kolli > > It is observed that while loading and unloading ath10k modules > in an infinite loop, before ath10k_core_start() completion HTT > rx frames are received, while processing these frames, > dereferencing the arvifs list code is getting hit before > initilizing the arvifs list, causing a kernel panic. > > This patch initilizes the arvifs list before initilizing htt. > > Fixes the below issue: > [] (ath10k_htt_rx_pktlog_completion_handler+0x278/0xd08 [ath10k_core]) > [] (ath10k_htt_rx_pktlog_completion_handler [ath10k_core]) > [] (ath10k_htt_txrx_compl_task+0x5f4/0xeb0 [ath10k_core]) > [] (ath10k_htt_txrx_compl_task [ath10k_core]) > [] (tasklet_action+0x8c/0xec) > [] (tasklet_action) > [] (__do_softirq+0xf8/0x228) > [] (__do_softirq) [] (run_ksoftirqd+0x30/0x90) > Code: e5954ad8 e2899008 e1540009 0a00000d (e5943008) > ---[ end trace 71de5c2e011dbf56 ]--- > Kernel panic - not syncing: Fatal exception in interrupt > > Fixes: 500ff9f9389d ("ath10k: implement chanctx API") > Cc: stable@vger.kernel.org > > Signed-off-by: Anilkumar Kolli Applied, thanks. -- Kalle Valo