Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33434 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbcERDfp (ORCPT ); Tue, 17 May 2016 23:35:45 -0400 From: Jes Sorensen To: Dan Lenski Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] rtl8xxxu: Increase default polling timeout for firmware startup References: <1463534086-22353-1-git-send-email-dlenski@gmail.com> <1463534086-22353-2-git-send-email-dlenski@gmail.com> Date: Tue, 17 May 2016 23:35:42 -0400 In-Reply-To: <1463534086-22353-2-git-send-email-dlenski@gmail.com> (Dan Lenski's message of "Tue, 17 May 2016 18:14:45 -0700") Message-ID: (sfid-20160518_053548_644102_FFE25AF9) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Lenski writes: > This patch increases the default value for the maximum number of polling > loops to wait for the rtl8xxxu MCU to start after the firmware is loaded > (from 1000 to 5000). > > With RTL8723AU chipset, I frequently encounter "Firmware failed to start" > errors from rtl8xxxu after a cold boot. > > It appears that other chipsets supported by the driver have the same > problem. Here are a couple of relevant bug reports: > - http://ubuntuforums.org/showthread.php?t=2321756 > - https://www.mail-archive.com/ubuntu-bugs@lists.ubuntu.com/msg4942468.html > > This issue seems to occur because RTL8XXXU_FIRMWARE_POLL_MAX (1000) is > too short, and the MCU fails to start up as quickly as expected. > > With a longer value (5000), the driver starts up consistently and > successfully after cold-boot. > > Signed-off-by: Dan Lenski > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) As previously pointed out, please provide some details about the system where this goes wrong. > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > index f2a1bac..39c6ce7 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h > @@ -49,7 +49,7 @@ > #define TX_PAGE_NUM_NORM_PQ 0x02 > > #define RTL_FW_PAGE_SIZE 4096 > -#define RTL8XXXU_FIRMWARE_POLL_MAX 1000 > +#define RTL8XXXU_FIRMWARE_POLL_MAX 5000 This is a long delay - how about 2000? Jes