Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:33050 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbcF1U5C (ORCPT ); Tue, 28 Jun 2016 16:57:02 -0400 Date: Tue, 28 Jun 2016 15:56:53 -0500 From: Rob Herring To: "Reizer, Eyal" Cc: "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-spi@vger.kernel.org" Subject: Re: [PATCH v4] wlcore: spi: add wl18xx support Message-ID: <20160628205653.GR3737@rob-hp-laptop> (sfid-20160628_225754_355281_92886273) References: <1466935675-14696-1-git-send-email-eyalr@ti.com> <8665E2433BC68541A24DFFCA87B70F5B3613BF60@DFRE01.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B3613BF60@DFRE01.ent.ti.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Jun 26, 2016 at 10:10:54AM +0000, Reizer, Eyal wrote: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - Use inverted chip select for sending a dummy 4 bytes command that > completes the init stage. > > Signed-off-by: Eyal Reizer > --- > v1->v2:update device tree bindings configuration > v2->v3:revert from manual gpio manipulation. use inverted chip select instead > for sending the extra init cycle which, achieves the same hardware purpose. > update device tree bindings docucmentation accordingly > v3->v4: Remove redundant data form binding documentation and fix chip select > number mismatch in wl1271 example > > .../bindings/net/wireless/ti,wlcore,spi.txt | 41 +++++-- Acked-by: Rob Herring > drivers/net/wireless/ti/wlcore/spi.c | 124 +++++++++++++++++---- > 2 files changed, 137 insertions(+), 28 deletions(-)