Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44323 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbcF3JC2 (ORCPT ); Thu, 30 Jun 2016 05:02:28 -0400 From: Kalle Valo To: Priit Laes Cc: arnd@arndb.de, Arend Van Spriel , Hans de Goede , Jonas Gorski , "John W . Linville" , Arend van Spriel , Maxime Ripard , Chen-Yu Tsai , "linux-wireless\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , devicetree , linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> <6402170.5s0abZDqlD@wuerfel> <1467230078.2598.2.camel@plaes.org> Date: Thu, 30 Jun 2016 12:02:17 +0300 In-Reply-To: <1467230078.2598.2.camel@plaes.org> (Priit Laes's message of "Wed, 29 Jun 2016 22:54:38 +0300") Message-ID: <87eg7f6odi.fsf@kamboji.qca.qualcomm.com> (sfid-20160630_110231_788952_D9C64DD7) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Priit Laes writes: >> What is the size of this nvram file? As it's board specific, I wonder >> if we can simply include it inside of the DT verbatim. I remember >> doing that (in the pre-dtb days, on real open firmware) for the >> "spidernet" >> ethernet driver. > > It contains a bit too much info: > > This is what CubieTruck requires: > > http://dl.cubieboard.org/public/Cubieboard/benn/firmware/ap6210/nvram_ap6210.txt In the nvram file I see lots of identifiers: manfid=0x2d0 prodid=0x492 vendid=0x14e4 devid=0x4343 boardtype=0x0598 boardrev=0x1307 boardnum=777 Are any of these (or a combination of them) unique for each board type? What if one of these is provided through DT and then the driver could choose the nvram file based on the board id? Just another idea... -- Kalle Valo