Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:60576 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbcFCFtN convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 01:49:13 -0400 Cc: Sudip Mukherjee , Stephen Rothwell , ath9k-devel , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ath9k-devel@lists.ath9k.org" , "netdev@vger.kernel.org" , Miaoqing Pan From: "Pan, Miaoqing" To: Kalle Valo Subject: Re: ath9k gpio request Date: Fri, 3 Jun 2016 05:49:06 +0000 Message-ID: <1464932944074.85131@qti.qualcomm.com> (sfid-20160603_074938_587568_3AAC514F) References: <20160530132225.4d297678@canb.auug.org.au> <574C4851.9090201@gmail.com> <87fusy3cqx.fsf_-_@kamboji.qca.qualcomm.com> <574D3EAA.3060102@gmail.com> <1464764036580.70506@qti.qualcomm.com> <574EC331.1080901@gmail.com> <574ED297.4080004@gmail.com> <1464854569880.79341@qti.qualcomm.com> <57501AE4.7080104@gmail.com>,<8760tqn8fc.fsf@purkki.adurom.net> In-Reply-To: <8760tqn8fc.fsf@purkki.adurom.net> Content-Type: text/plain; charset=US-ASCII MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Done, https://patchwork.kernel.org/patch/9151847/. Thanks, Miaoqing ________________________________________ From: Kalle Valo Sent: Friday, June 3, 2016 1:33 PM To: Pan, Miaoqing Cc: Sudip Mukherjee; Stephen Rothwell; ath9k-devel; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; linux-wireless@vger.kernel.org; ath9k-devel@lists.ath9k.org; netdev@vger.kernel.org; Miaoqing Pan Subject: Re: ath9k gpio request Sudip Mukherjee writes: > On Thursday 02 June 2016 01:32 PM, Pan, Miaoqing wrote: >> Seems there are something wrong in the datasheet, try >> >> --- a/drivers/net/wireless/ath/ath9k/reg.h >> +++ b/drivers/net/wireless/ath/ath9k/reg.h >> @@ -1122,8 +1122,8 @@ enum { >> #define AR9300_NUM_GPIO 16 >> #define AR9330_NUM_GPIO 16 >> #define AR9340_NUM_GPIO 23 >> -#define AR9462_NUM_GPIO 10 >> -#define AR9485_NUM_GPIO 12 >> +#define AR9462_NUM_GPIO 14 >> +#define AR9485_NUM_GPIO 11 >> #define AR9531_NUM_GPIO 18 >> #define AR9550_NUM_GPIO 24 >> #define AR9561_NUM_GPIO 23 >> @@ -1139,8 +1139,8 @@ enum { >> #define AR9300_GPIO_MASK 0x0000F4FF >> #define AR9330_GPIO_MASK 0x0000F4FF >> #define AR9340_GPIO_MASK 0x0000000F >> -#define AR9462_GPIO_MASK 0x000003FF >> -#define AR9485_GPIO_MASK 0x00000FFF >> +#define AR9462_GPIO_MASK 0x00003FFF >> +#define AR9485_GPIO_MASK 0x000007FF >> #define AR9531_GPIO_MASK 0x0000000F >> #define AR9550_GPIO_MASK 0x0000000F >> #define AR9561_GPIO_MASK 0x0000000F > > solves the problem. > > Tested-by: Sudip Mukherjee Great, thanks for testing everyone. Miaoqing, please send a proper patch ASAP and I'll push it to 4.7. -- Kalle Valo