Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:36696 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766AbcFBJsp (ORCPT ); Thu, 2 Jun 2016 05:48:45 -0400 Received: by mail-wm0-f49.google.com with SMTP id n184so71107276wmn.1 for ; Thu, 02 Jun 2016 02:48:44 -0700 (PDT) Date: Thu, 2 Jun 2016 10:48:42 +0100 From: Matt Fleming To: Lukas Wunner Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Chris Milsted , Matthew Garrett , Andi Kleen , Michael Buesch , Bjorn Helgaas , Konstantin Simanov , Bryan Paradis , Andrew Worsley , Chris Bainbridge , Linus Torvalds , linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, zajec5@gmail.com Subject: Re: [PATCH] x86: Add early quirk to reset Apple AirPort card Message-ID: <20160602094842.GF2658@codeblueprint.co.uk> (sfid-20160602_114905_441344_D513B031) References: <82c2548dffc6cfbc484b9111b1073f407c946061.1464477483.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <82c2548dffc6cfbc484b9111b1073f407c946061.1464477483.git.lukas@wunner.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 29 May, at 01:35:28AM, Lukas Wunner wrote: > The EFI firmware on Macs contains a full-fledged network stack for > downloading OS X images from osrecovery.apple.com. Unfortunately > on Macs introduced 2011 and 2012, EFI brings up the Broadcom 4331 > wireless card on every boot and leaves it enabled even after > ExitBootServices has been called. The card continues to assert its IRQ > line, causing spurious interrupts if the IRQ is shared. It also corrupts > memory by DMAing received packets, allowing for remote code execution > over the air. This only stops when a driver is loaded for the wireless > card, which may be never if the driver is not installed or blacklisted. [... Snip a very thorough changelog ...] This patch looks fine to me from an EFI perspective. Acked-by: Matt Fleming