Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39375 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbcF3JtK (ORCPT ); Thu, 30 Jun 2016 05:49:10 -0400 Subject: Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property To: Kalle Valo , Arend Van Spriel References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> <871t3gdj6p.fsf@purkki.adurom.net> <87mvm36p4d.fsf@kamboji.qca.qualcomm.com> Cc: Jonas Gorski , "John W . Linville" , Arend van Spriel , Maxime Ripard , Chen-Yu Tsai , "linux-wireless@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , devicetree , linux-sunxi@googlegroups.com From: Hans de Goede Message-ID: <4f1a8cce-91e9-f386-cdde-7abcdc43b817@redhat.com> (sfid-20160630_114914_363584_9471FEF6) Date: Thu, 30 Jun 2016 11:49:01 +0200 MIME-Version: 1.0 In-Reply-To: <87mvm36p4d.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On 30-06-16 10:46, Kalle Valo wrote: > Arend Van Spriel writes: > >>> Since we are dealing with a per-board config-file here, which is >>> loaded from the os filesystem we really need to specify a basename >>> here as the list of possible boards is endless, so we cannot >>> have a lookup table in the driver. >> >> As Jonas mentioned the general principle of device tree is to be >> agnostic with regards to OS and/or driver as you undoubtedly know. His >> proposal seems like a usable solution for your problem while complying >> to the device tree principle. So instead of overriding the default >> brcmfmac should modify it when dt specifies the "module" property, ie: >> >> no "module" in DT: nvram filename = brcm/brcmfmac43362-sdio.txt >> "module=ap6210" in DT: nvram filename = brcm/brcmfmac43362-ap6210.txt > > Just out of curiosity, what does "ap6210" exactly mean? I get that 43362 > is the chip id, but not ap6210. Is it just an arbitrary name? It is more or less an arbitrary name, typically these sdio wifi chips are used as a pre-assembled module (a tiny pcb) with some things like the necessary crystal / resonator and various capacitors and resistors on there. The brcm based sdio wifi modules typically come with a metal shield cap which has a module type stamped on it, e.g. ap6210, ap6476, toc9002. Regards, Hans