Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45651 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161453AbcFMTAw (ORCPT ); Mon, 13 Jun 2016 15:00:52 -0400 Date: Mon, 13 Jun 2016 21:00:48 +0200 From: Pavel Machek To: =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita Cc: Johannes Berg , "David S. Miller" , Darren Hart , linux-wireless , Network Development , platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, LKML , linux@endlessm.com, =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita Subject: Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger Message-ID: <20160613190048.GA17101@amd> (sfid-20160613_210129_973272_01578C2D) References: <1462199948-6424-1-git-send-email-jprvita@endlessm.com> <1462199948-6424-2-git-send-email-jprvita@endlessm.com> <20160504072936.GB17045@amd> <1463045572.13313.21.camel@sipsolutions.net> <20160519071639.GB17077@amd> <1465476194.3442.21.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi! > > Jo?o, that means you should send a patch to add the ::rfkill suffix. > > > > IMO "airplane" (or maybe "airplane-mode") is a better suffix, as it > reflects the label on the machine's chassis. I'll name it > "asus-wireless::airplane" and send this through platform-drivers-x86, > as this is now contained in the platform-drivers-x86 subsystem. Thanks > Johannes for your patience and help designing and reviewing the rfkill > changes, even if not all of them made it through in the end. And > thanks everyone else involved for the feedback. Actually, I'd do '::rfkill', for consistency with other places in /sys. /sys/devices/platform/thinkpad_acpi/rfkill/rfkill1/name /sys/class/rfkill /sys/module/rfkill Thanks for patience, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html