Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:44346 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbcFBPVn (ORCPT ); Thu, 2 Jun 2016 11:21:43 -0400 Message-ID: <57504F05.3040200@candelatech.com> (sfid-20160602_172146_479483_A759A6DF) Date: Thu, 02 Jun 2016 08:21:41 -0700 From: Ben Greear MIME-Version: 1.0 To: "Valo, Kalle" , "ath10k@lists.infradead.org" CC: "Manoharan, Rajkumar" , "linux-wireless@vger.kernel.org" , "mike@fireburn.co.uk" Subject: Re: Bug 119151 - [regression] ath10k no longer authenitcates and freezes system References: <8760trzoiw.fsf@kamboji.qca.qualcomm.com> <871t4fzn1x.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <871t4fzn1x.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/02/2016 07:24 AM, Valo, Kalle wrote: > Kalle Valo writes: > >> there's a regression in ath10k: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=119151 >> >> Reporter bisected it to this: >> >> 5c86d97bcc1d42ce7f75685a61be4dad34ee8183 is the first bad commit >> commit 5c86d97bcc1d42ce7f75685a61be4dad34ee8183 >> Author: Rajkumar Manoharan >> Date: Tue Mar 22 17:22:19 2016 +0530 >> >> ath10k: combine txrx and replenish task >> >> Since tx completion and rx indication processing are moved out >> of txrx tasklet and rx ring lock contention also removed from txrx >> for rx_ind messages, it would be efficient to combine both replenish >> and txrx tasks. Refill threshold is adjusted for both AP135 and AP148 >> (low and high end systems). With this adjustment in AP135, TCP DL is >> improved from 603 Mbps to 620 Mbps and UDP DL is improved from 758 Mbps >> to 803 Mbps. Also no watchdog are observed on UDP BiDi. >> >> Signed-off-by: Rajkumar Manoharan >> Signed-off-by: Kalle Valo > > Adding Mike, the bug reporter. I found a lot of problems with this code as well, and the 5 patches starting from the URL below fixed the issues for me. They are stuck as 'NA' in patchwork, but I don't know why. http://lists.infradead.org/pipermail/ath10k/2016-April/007218.html You probably need this patch as well, or ath10k will crash when you enable the debug-mask: http://permalink.gmane.org/gmane.linux.kernel.wireless.general/151890 It is also 'NA' in patchwork. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com