Return-path: Received: from smtp-out6.electric.net ([192.162.217.189]:51796 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbcFPQKF convert rfc822-to-8bit (ORCPT ); Thu, 16 Jun 2016 12:10:05 -0400 From: David Laight To: 'Arnd Bergmann' , Jes Sorensen CC: Kalle Valo , Larry Finger , Chaoming Li , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] rtlwifi: use s8 instead of char Date: Thu, 16 Jun 2016 16:02:38 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D5F4DA915@AcuExch.aculab.com> (sfid-20160616_181016_370262_CC5F4815) References: <20160615210318.4130648-1-arnd@arndb.de> <5245411.kmNEkqpVVS@wuerfel> In-Reply-To: <5245411.kmNEkqpVVS@wuerfel> Content-Type: text/plain; charset="Windows-1252" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Arnd Bergmann > On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote: > > > > Arnd, > > > > rtlwifi and rtl8xxxu are two distinct drivers managed by different > > people. I'd be really nice if you could split this into a per driver > > patch. > > > > That said, the use of char in rtl8xxxu is all as a flag indicator, so I > > don't think the s/char/s8/ conversion is justified. I used char rather > > than ugly bool to reduce the size of the struct. > > Makes sense, I'll resend without that change. If anything, the flag > should become u8, not s8 anyway. Does bool:8 work ? David