Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:35500 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbcFAEPd (ORCPT ); Wed, 1 Jun 2016 00:15:33 -0400 MIME-Version: 1.0 In-Reply-To: <1464358702-19083-3-git-send-email-javier@osg.samsung.com> References: <1464358702-19083-1-git-send-email-javier@osg.samsung.com> <1464358702-19083-3-git-send-email-javier@osg.samsung.com> From: Julian Calaby Date: Wed, 1 Jun 2016 14:15:12 +1000 Message-ID: (sfid-20160601_061551_035661_DC241B24) Subject: Re: [PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe() To: Javier Martinez Canillas Cc: "linux-kernel@vger.kernel.org" , Xinming Hu , Amitkumar Karwar , Kalle Valo , netdev , linux-wireless , Nishant Sarmukadam Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > If the sdio_enable_func() function fails on .probe, the -EIO errno code > is always returned but that could make more difficult to debug and find > the cause of why the function actually failed. > > Since the driver/device core prints the value returned by .probe in its > error message propagate what was returned by sdio_enable_func() at fail. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/