Return-path: Received: from nbd.name ([46.4.11.11]:59607 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbcF0K0o (ORCPT ); Mon, 27 Jun 2016 06:26:44 -0400 Subject: Re: [PATCH v3 2/3] ath9k: add a helper to get the string representation of ath_bus_type To: Martin Blumenstingl , ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org References: <20160624123430.4097-1-martin.blumenstingl@googlemail.com> <20160624123430.4097-3-martin.blumenstingl@googlemail.com> Cc: chunkeey@googlemail.com, mark.rutland@arm.com, robh+dt@kernel.org, arend.vanspriel@broadcom.com From: Felix Fietkau Message-ID: (sfid-20160627_122656_288940_5F0426A2) Date: Mon, 27 Jun 2016 12:26:36 +0200 MIME-Version: 1.0 In-Reply-To: <20160624123430.4097-3-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2016-06-24 14:34, Martin Blumenstingl wrote: > Signed-off-by: Martin Blumenstingl > --- > this is a new patch which didn't exist in v2 yet, it prepares the new > function ath_bus_type_to_string which will be used in patch #3 > > drivers/net/wireless/ath/ath.h | 2 ++ > drivers/net/wireless/ath/main.c | 15 +++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h > index da7a7c8..be0d292 100644 > --- a/drivers/net/wireless/ath/ath.h > +++ b/drivers/net/wireless/ath/ath.h > @@ -327,4 +327,6 @@ static inline const char *ath_opmode_to_string(enum nl80211_iftype opmode) > } > #endif > > +const char *ath_bus_type_to_string(enum ath_bus_type bustype); > + > #endif /* ATH_H */ > diff --git a/drivers/net/wireless/ath/main.c b/drivers/net/wireless/ath/main.c > index 338d723..90427cb 100644 > --- a/drivers/net/wireless/ath/main.c > +++ b/drivers/net/wireless/ath/main.c > @@ -90,3 +90,18 @@ void ath_printk(const char *level, const struct ath_common* common, > va_end(args); > } > EXPORT_SYMBOL(ath_printk); > + > +const char *ath_bus_type_to_string(enum ath_bus_type bustype) > +{ > + switch (bustype) { > + case ATH_PCI: > + return "pci"; > + case ATH_AHB: > + return "ahb"; > + case ATH_USB: > + return "usb"; > + default: > + return "unknown"; > + } > +} > +EXPORT_SYMBOL(ath_bus_type_to_string); Why not simply add a const char* array with ath_bus_type as index? - Felix