Return-path: Received: from mail-oi0-f68.google.com ([209.85.218.68]:33367 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964806AbcFAERj (ORCPT ); Wed, 1 Jun 2016 00:17:39 -0400 MIME-Version: 1.0 In-Reply-To: <1464358702-19083-4-git-send-email-javier@osg.samsung.com> References: <1464358702-19083-1-git-send-email-javier@osg.samsung.com> <1464358702-19083-4-git-send-email-javier@osg.samsung.com> From: Julian Calaby Date: Wed, 1 Jun 2016 14:17:19 +1000 Message-ID: (sfid-20160601_061806_505706_33CBE1F6) Subject: Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe() To: Javier Martinez Canillas Cc: "linux-kernel@vger.kernel.org" , Xinming Hu , Amitkumar Karwar , Kalle Valo , netdev , linux-wireless , Nishant Sarmukadam Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas wrote: > There's only a check if mwifiex_add_card() returned a nonzero value, but > the actual error code is neither stored nor propagated to the caller. So > instead of always returning -1 (which is -EPERM and not a suitable errno > code in this case), propagate the value returned by mwifiex_add_card(). > > Patch also removes the assignment of sdio_disable_func() returned value > since it was overwritten anyways and what matters is to know the error > value returned by the first function that failed. > > Signed-off-by: Javier Martinez Canillas This looks sensible to me. Reviewed-by: Julian Calaby > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/