Return-path: Received: from nm.newmedia-net.de ([217.113.179.122]:42025 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755863AbcGHSYa (ORCPT ); Fri, 8 Jul 2016 14:24:30 -0400 To: Felix Fietkau , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <87wpkwktx9.fsf@toke.dk> <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> <87lh1cksao.fsf@toke.dk> Cc: Kalle Valo , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard From: Sebastian Gottschall Message-ID: (sfid-20160708_202437_020976_0A595957) Date: Fri, 8 Jul 2016 20:24:08 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [v3] ath9k: Switch to using mac80211 intermediate software queues. Sender: linux-wireless-owner@vger.kernel.org List-ID: for me it crashes on wds sta on 3.18 kernels. need to solder a serial to get more logs Am 08.07.2016 um 18:31 schrieb Felix Fietkau: > On 2016-07-08 18:28, Toke Høiland-Jørgensen wrote: >> Felix Fietkau writes: >> >>> On 2016-07-08 17:53, Toke Høiland-Jørgensen wrote: >>>> Kalle Valo writes: >>>> >>>>> Toke Høiland-Jørgensen wrote: >>>>>> This switches ath9k over to using the mac80211 intermediate software >>>>>> queueing mechanism for data packets. It removes the queueing inside the >>>>>> driver, except for the retry queue, and instead pulls from mac80211 when >>>>>> a packet is needed. The retry queue is used to store a packet that was >>>>>> pulled but can't be sent immediately. >>>>>> >>>>>> The old code path in ath_tx_start that would queue packets has been >>>>>> removed completely, as has the qlen limit tunables (since there's no >>>>>> longer a queue in the driver to limit). >>>>>> >>>>>> Based on Tim's original patch set, but reworked quite thoroughly. >>>>>> >>>>>> Cc: Tim Shepard >>>>>> Cc: Felix Fietkau >>>>>> Signed-off-by: Toke Høiland-Jørgensen >>>>> Nice work. >>>> Thanks :) >>>> >>>>> Because this is such a significant change, and to maximise testing >>>>> time, I'm planning to queue this for 4.9 (so I would apply this to >>>>> ath-next in 3-4 weeks after the merge window closes). But anyone who >>>>> wants to test this can use master-pending branch from my ath.git tree >>>>> (uses wireless-testing as the baseline). Sounds good? >>>> Sounds good to me. I'm planning on backporting this and Michael's >>>> mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. >>>> Hopefully that will get it some more testing as well. >>> I've pushed a backport of this into my LEDE staging tree: >>> https://git.lede-project.org/?p=lede/nbd/staging.git;a=summary >> Awesome! What about the FQ-CoDel mac80211 patches themselves? I have a >> tree where I've separated out the needed patches and rebased them on >> mainline 4.4.9. Can I post that somewhere (or just email you the series) >> and get you to include those as well? Or do I just dump the patch files >> into the LEDE patches dir and send that as a patch to LEDE? (I see your >> patch also refreshed subsequent patches; is there a script to do that >> automatically?) > You don't need to do anything here. LEDE does not use mac80211 and > drivers from the kernel tree, it's built using backports. > It's currently using a backports snapshot that I built myself from > wireless-testing 2016-06-20, which already includes FQ-Codel. > > - Felix > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565