Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41393 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbcGOL2c (ORCPT ); Fri, 15 Jul 2016 07:28:32 -0400 Date: Fri, 15 Jul 2016 13:25:53 +0200 From: Stanislaw Gruszka To: "Grumbach, Emmanuel" Cc: "prarit@redhat.com" , "linux-kernel@vger.kernel.org" , linuxwifi , "Coelho, Luciano" , "Berg, Johannes" , "kvalo@codeaurora.org" , "Ivgi, Chaya Rachel" , "netdev@vger.kernel.org" , "Sharon, Sara" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Message-ID: <20160715112552.GB6939@redhat.com> (sfid-20160715_132852_471774_1CD55F6F) References: <1468250301-10357-1-git-send-email-prarit@redhat.com> <5783E33E.7090205@redhat.com> <1468261650.20877.14.camel@intel.com> <20160714092408.GA27271@redhat.com> <0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jul 14, 2016 at 09:44:22AM +0000, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the > > time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ). > > Cur_ucode will not be IWL_UCODE_REGULAR until you load the firmware which > will happen upon ifup. Then creating thermal_device on ifup looks more reasonable to me. Otherwise we can create device that can be non-functional virtually forever, i.e. when soft RFKILL is enabled. However I admit that creating thermal_device when HW is detected has some advantages too. Stanislaw