Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54444 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754981AbcGENQ1 (ORCPT ); Tue, 5 Jul 2016 09:16:27 -0400 From: Kalle Valo To: Jakub Kicinski Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, hannes@stressinduktion.org, nbd@nbd.name, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h References: <1467718979-20029-1-git-send-email-jakub.kicinski@netronome.com> <1467718979-20029-3-git-send-email-jakub.kicinski@netronome.com> Date: Tue, 05 Jul 2016 16:16:20 +0300 In-Reply-To: <1467718979-20029-3-git-send-email-jakub.kicinski@netronome.com> (Jakub Kicinski's message of "Tue, 5 Jul 2016 12:42:59 +0100") Message-ID: <87poqs2pjv.fsf@kamboji.qca.qualcomm.com> (sfid-20160705_151647_751562_5D4432F6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Jakub Kicinski writes: > Use the newly added linux/bitfield.h. > > Signed-off-by: Jakub Kicinski [...] > +#define MT76_SET FIELD_PUT > +#define MT76_GET FIELD_GET This define is useless now, I would just remove it entirely. But you can do that in a follow up patch. -- Kalle Valo