Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:38249 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbcGBSAm (ORCPT ); Sat, 2 Jul 2016 14:00:42 -0400 Received: by mail-wm0-f45.google.com with SMTP id r201so66578431wme.1 for ; Sat, 02 Jul 2016 11:00:41 -0700 (PDT) Subject: Re: [patch] mwifiex: fix mwifiex_add_virtual_intf() To: Dan Carpenter , Amitkumar Karwar References: <20160702072045.GA25758@mwanda> Cc: Nishant Sarmukadam , Kalle Valo , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org From: Arend Van Spriel Message-ID: (sfid-20160702_200050_711935_B481C775) Date: Sat, 2 Jul 2016 20:00:33 +0200 MIME-Version: 1.0 In-Reply-To: <20160702072045.GA25758@mwanda> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2-7-2016 9:20, Dan Carpenter wrote: > We accidentally left some if statements out so the > mwifiex_add_virtual_intf() function returns early. > > Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added interface') > Signed-off-by: Dan Carpenter Someone beat you to it [1] ;-) Regards, Arend [1] http://mid.gmane.org/1467401982-18943-1-git-send-email-javier@osg.samsung.com > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index 99e8cf1..5de9f63 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy, > > ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE, > HostCmd_ACT_GEN_SET, 0, NULL, true); > + if (ret) > return ERR_PTR(ret); > > ret = mwifiex_sta_init_cmd(priv, false, false); > + if (ret) > return ERR_PTR(ret); > > mwifiex_setup_ht_caps(&wiphy->bands[NL80211_BAND_2GHZ]->ht_cap, priv); > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >