Return-path: Received: from mout.kundenserver.de ([212.227.126.187]:60042 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbcGTP0e (ORCPT ); Wed, 20 Jul 2016 11:26:34 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org, Kalle Valo , Larry Finger , netdev@vger.kernel.org, Jes Sorensen , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0 Date: Wed, 20 Jul 2016 17:26:06 +0200 Message-Id: <20160720152606.201775-2-arnd@arndb.de> (sfid-20160720_172713_875357_0B9E5B6D) In-Reply-To: <20160720152606.201775-1-arnd@arndb.de> References: <20160720151818.4142386-1-arnd@arndb.de> <20160720152606.201775-1-arnd@arndb.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: There is one remaining warning about a type limit check in rtl8192e: staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true due to limited range of data type [-Werror=type-limits] This changes a macro into a local function to clarify the types and simplify the check while removing the warning. Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8192e/rtl819x_Qos.h | 3 --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 +++++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h b/drivers/staging/rtl8192e/rtl819x_Qos.h index 463122db6d29..61da8f7475bb 100644 --- a/drivers/staging/rtl8192e/rtl819x_Qos.h +++ b/drivers/staging/rtl8192e/rtl819x_Qos.h @@ -169,9 +169,6 @@ union qos_tclas { } TYPE2_8021Q; }; -#define IsACValid(ac) ((ac >= 0 && ac <= 7) ? true : false) - - union aci_aifsn { u8 charData; diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c index 2c8a526773ed..a966a8e490ab 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -306,6 +306,11 @@ static void MakeTSEntry(struct ts_common_info *pTsCommonInfo, u8 *Addr, pTsCommonInfo->TClasNum = TCLAS_Num; } +static bool IsACValid(unsigned int tid) +{ + return tid < 7; +} + bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS, u8 *Addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs) { -- 2.9.0