Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53791 "EHLO smtp.codeaurora.org" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751112AbcGMPtW (ORCPT ); Wed, 13 Jul 2016 11:49:22 -0400 From: Kalle Valo To: Amitkumar Karwar Cc: "linux-wireless\@vger.kernel.org" , "Cathy Luo" , Nishant Sarmukadam , Xinming Hu Subject: Re: [PATCH v3 2/2] mwifiex: add hostcmd wext ioctl support References: <1468417703-32716-1-git-send-email-akarwar@marvell.com> <1468417703-32716-2-git-send-email-akarwar@marvell.com> <87y455a7u3.fsf@purkki.adurom.net> <35fedc2035a64135a4d995aca379d4e9@SC-EXCH04.marvell.com> Date: Wed, 13 Jul 2016 18:48:18 +0300 In-Reply-To: <35fedc2035a64135a4d995aca379d4e9@SC-EXCH04.marvell.com> (Amitkumar Karwar's message of "Wed, 13 Jul 2016 15:25:58 +0000") Message-ID: <87inw9zghp.fsf@kamboji.qca.qualcomm.com> (sfid-20160713_174933_251125_879A9772) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Amitkumar Karwar writes: > Hi Kalle, > >> -----Original Message----- >> From: Kalle Valo [mailto:kvalo@codeaurora.org] >> Sent: Wednesday, July 13, 2016 8:44 PM >> To: Amitkumar Karwar >> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; >> Xinming Hu >> Subject: Re: [PATCH v3 2/2] mwifiex: add hostcmd wext ioctl support >> >> Amitkumar Karwar writes: >> >> > From: Xinming Hu >> > >> > This patch adds ndo_ioctl support to mwifiex netdev handlers. >> > This will be used to download hostcmds to firmware from userspace. >> > This is needed for manufacturing mode support in mwifiex. ndo_ioctl is >> > allowed only when mfg mode is enabled via module load parameters. >> > >> > Signed-off-by: Xinming Hu >> > Signed-off-by: Amitkumar Karwar >> > --- >> > v3: Add "select WIRELESS_EXT" in Kconfig to resolve kbuild test robot >> errors. >> > WEXT_PRIV seems to have a dependency with WIRELESS_EXT. >> > v2: 1) Sequence of these two patches are changed to resolve >> compilation >> > error seen if only 1/2 is applied. >> > 2) Add "select WEXT_PRIV" in Kconfig to resolve warnings reported >> by >> > kbuild test robot. >> >> Why can't you use nl80211 testmode interface? > > These two patches facilitates user to configure manufacturing mode. We > have a separate firmware for this mode. It's needed to run special > WiFi conductive and radiated tests at factory. This is exactly what nl80211 testmode is for. > The userspace tools used for this purpose expects WEXT interface. So convert them to use nl80211. I have done that myself, multiple times actually. And for wireless extensions, from my point of view it's dead and buried. I'm not going to take any new wireless extension related code. -- Kalle Valo