Return-path: Received: from mail-it0-f53.google.com ([209.85.214.53]:37089 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbcHAJ7h convert rfc822-to-8bit (ORCPT ); Mon, 1 Aug 2016 05:59:37 -0400 Received: by mail-it0-f53.google.com with SMTP id f6so165295328ith.0 for ; Mon, 01 Aug 2016 02:59:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1463489221-24989-1-git-send-email-michal.kazior@tieto.com> <1467201146-6844-1-git-send-email-michal.kazior@tieto.com> <87zipt1kco.fsf@kamboji.qca.qualcomm.com> From: Dave Taht Date: Mon, 1 Aug 2016 11:04:56 +0200 Message-ID: (sfid-20160801_120253_514618_0C0DEA22) Subject: Re: [PATCH] ath10k: disable wake_tx_queue for older devices To: Roman Yeryomin Cc: "Valo, Kalle" , "linux-wireless@vger.kernel.org" , "michal.kazior@tieto.com" , "ath10k@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Aug 1, 2016 at 1:35 AM, Roman Yeryomin wrote: > On 7 July 2016 at 19:30, Valo, Kalle wrote: >> Michal Kazior writes: >> >>> Ideally wake_tx_queue should be used regardless as >>> it is a requirement for reducing bufferbloat and >>> implementing airtime fairness in the future. >>> >>> However some setups (typically low-end platforms >>> hosting QCA988X) suffer performance regressions >>> with the current wake_tx_queue implementation. >>> Therefore disable it unless it is really >>> beneficial with current codebase (which is when >>> firmware supports smart pull-push tx scheduling). >>> >>> Signed-off-by: Michal Kazior >> >> I think it's too late to send this to 4.7 anymore (and this due to my >> vacation). So I'm planning to queue this to 4.8, but if the feedback is >> positive we can always send this to a 4.7 stable release. >> > > Sorry guys, drowned. > So, yes, applying this patch does the job. That is gets me to the > results similar to > https://lists.openwrt.org/pipermail/openwrt-devel/2016-May/041448.html > > Going to try latest code on same system... Can you try increasing the quantum to 1514, and reducing the codel target to 5ms? (without this patch?) > > Regards, > Roman > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k -- Dave Täht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org