Return-path: Received: from mga04.intel.com ([192.55.52.120]:10128 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934503AbcHBM0j (ORCPT ); Tue, 2 Aug 2016 08:26:39 -0400 From: Baole Ni To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, kvalo@codeaurora.org, linuxwifi@intel.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0801/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:47:53 +0800 Message-Id: <20160802114753.3366-1-baolex.ni@intel.com> (sfid-20160802_174024_930938_6084721D) Sender: linux-wireless-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c index 4159f9b..fec4969 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c @@ -433,15 +433,15 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek 8821ae 802.11ac PCI wireless"); MODULE_FIRMWARE("rtlwifi/rtl8821aefw.bin"); -module_param_named(swenc, rtl8821ae_mod_params.sw_crypto, bool, 0444); -module_param_named(debug, rtl8821ae_mod_params.debug, int, 0444); -module_param_named(ips, rtl8821ae_mod_params.inactiveps, bool, 0444); -module_param_named(swlps, rtl8821ae_mod_params.swctrl_lps, bool, 0444); -module_param_named(fwlps, rtl8821ae_mod_params.fwctrl_lps, bool, 0444); -module_param_named(msi, rtl8821ae_mod_params.msi_support, bool, 0444); +module_param_named(swenc, rtl8821ae_mod_params.sw_crypto, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(debug, rtl8821ae_mod_params.debug, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(ips, rtl8821ae_mod_params.inactiveps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(swlps, rtl8821ae_mod_params.swctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(fwlps, rtl8821ae_mod_params.fwctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(msi, rtl8821ae_mod_params.msi_support, bool, S_IRUSR | S_IRGRP | S_IROTH); module_param_named(disable_watchdog, rtl8821ae_mod_params.disable_watchdog, - bool, 0444); -module_param_named(int_clear, rtl8821ae_mod_params.int_clear, bool, 0444); + bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(int_clear, rtl8821ae_mod_params.int_clear, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n"); MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n"); MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n"); -- 2.9.2