Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:36445 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932187AbcHIJAS (ORCPT ); Tue, 9 Aug 2016 05:00:18 -0400 Date: Tue, 9 Aug 2016 16:58:58 +0800 From: Herbert Xu To: Stephan Mueller Cc: "Pan, Miaoqing" , Matt Mackall , "miaoqing@codeaurora.org" , "Valo, Kalle" , "linux-wireless@vger.kernel.org" , ath9k-devel , "linux-crypto@vger.kernel.org" , "jason@lakedaemon.net" , "Sepehrdad, Pouyan" Subject: Re: [PATCH 2/2] ath9k: disable RNG by default Message-ID: <20160809085858.GA6172@gondor.apana.org.au> (sfid-20160809_110023_515840_C9D1741B) References: <1470726147-30095-1-git-send-email-miaoqing@codeaurora.org> <4627645.oz3l49ICL3@tauon.atsec.com> <69af156ac93a4fe6ab1844dfcc35c266@aptaiexm02f.ap.qualcomm.com> <4731753.YZZKimtrHM@tauon.atsec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4731753.YZZKimtrHM@tauon.atsec.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 09, 2016 at 10:07:29AM +0200, Stephan Mueller wrote: > > Herbert, Matt, should such noise sources be added to the HW random framework? > The thing is that the in-kernel HW random to input_pool link per default uses > a more conservative entropy estimate than the user space rngd. I would think > that the in-kernel link would appropriate for that rng. But the user space > rngd tool with its default behavior is not really suited here. Yes hwrng would be the best fit, with a quality of zero to be safe. Contrary to the quoted thread, there is no need to whiten the output /dev/hw_random. It was always meant to go through some intermediate processing such as rngd before it is used. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt