Return-path: Received: from mga11.intel.com ([192.55.52.93]:26337 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934389AbcHBM0j (ORCPT ); Tue, 2 Aug 2016 08:26:39 -0400 From: Baole Ni To: pizza@shaftnet.org, kvalo@codeaurora.org, linuxwifi@intel.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0804/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:48:07 +0800 Message-Id: <20160802114807.3566-1-baolex.ni@intel.com> (sfid-20160802_174020_425958_E61D485D) Sender: linux-wireless-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/wireless/st/cw1200/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c index daf06a4..fad0c81 100644 --- a/drivers/net/wireless/st/cw1200/sta.c +++ b/drivers/net/wireless/st/cw1200/sta.c @@ -144,7 +144,7 @@ void cw1200_stop(struct ieee80211_hw *dev) } static int cw1200_bssloss_mitigation = 1; -module_param(cw1200_bssloss_mitigation, int, 0644); +module_param(cw1200_bssloss_mitigation, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(cw1200_bssloss_mitigation, "BSS Loss mitigation. 0 == disabled, 1 == enabled (default)"); -- 2.9.2