Return-path: Received: from mail.eperm.de ([89.247.134.16]:34288 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbcHIJDC (ORCPT ); Tue, 9 Aug 2016 05:03:02 -0400 From: Stephan Mueller To: Herbert Xu Cc: "Pan, Miaoqing" , Matt Mackall , "miaoqing@codeaurora.org" , "Valo, Kalle" , "linux-wireless@vger.kernel.org" , ath9k-devel , "linux-crypto@vger.kernel.org" , "jason@lakedaemon.net" , "Sepehrdad, Pouyan" Subject: Re: [PATCH 2/2] ath9k: disable RNG by default Date: Tue, 09 Aug 2016 11:02:58 +0200 Message-ID: <2569442.q63FVBJjUH@tauon.atsec.com> (sfid-20160809_110305_816940_805319C1) In-Reply-To: <20160809085858.GA6172@gondor.apana.org.au> References: <1470726147-30095-1-git-send-email-miaoqing@codeaurora.org> <4731753.YZZKimtrHM@tauon.atsec.com> <20160809085858.GA6172@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Am Dienstag, 9. August 2016, 16:58:58 CEST schrieb Herbert Xu: Hi Herbert, > On Tue, Aug 09, 2016 at 10:07:29AM +0200, Stephan Mueller wrote: > > Herbert, Matt, should such noise sources be added to the HW random > > framework? The thing is that the in-kernel HW random to input_pool link > > per default uses a more conservative entropy estimate than the user space > > rngd. I would think that the in-kernel link would appropriate for that > > rng. But the user space rngd tool with its default behavior is not really > > suited here. > > Yes hwrng would be the best fit, with a quality of zero to be safe. > > Contrary to the quoted thread, there is no need to whiten the output > /dev/hw_random. It was always meant to go through some intermediate > processing such as rngd before it is used. But shouldn't the default of the rngd then be adjusted a bit? > > Cheers, Ciao Stephan