Return-path: Received: from mga01.intel.com ([192.55.52.88]:40465 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934643AbcHBM0j (ORCPT ); Tue, 2 Aug 2016 08:26:39 -0400 From: Baole Ni To: j@w1.fi, kvalo@codeaurora.org, luciano.coelho@intel.com, linuxwifi@intel.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lars@metafoo.de, johannes.berg@intel.com Subject: [PATCH 0779/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:45:34 +0800 Message-Id: <20160802114534.1675-1-baolex.ni@intel.com> (sfid-20160802_173811_053733_70888073) Sender: linux-wireless-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/wireless/intersil/hostap/hostap_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intersil/hostap/hostap_cs.c b/drivers/net/wireless/intersil/hostap/hostap_cs.c index 74f63b7..5329e11 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_cs.c +++ b/drivers/net/wireless/intersil/hostap/hostap_cs.c @@ -30,7 +30,7 @@ MODULE_LICENSE("GPL"); static int ignore_cis_vcc; -module_param(ignore_cis_vcc, int, 0444); +module_param(ignore_cis_vcc, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ignore_cis_vcc, "Ignore broken CIS VCC entry"); -- 2.9.2