Return-path: Received: from mail-wm0-f48.google.com ([74.125.82.48]:37424 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbcHOVoK (ORCPT ); Mon, 15 Aug 2016 17:44:10 -0400 Received: by mail-wm0-f48.google.com with SMTP id i5so128776671wmg.0 for ; Mon, 15 Aug 2016 14:44:09 -0700 (PDT) Subject: Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo References: <147125403645.9434.8008546579326856373.stgit@devbox> <147125405701.9434.12911635695339175773.stgit@devbox> <5bb6e373-e110-b1ac-6f65-fdf2f9f059fc@gmail.com> <87wpjib8pb.fsf@kamboji.qca.qualcomm.com> Cc: Masami Hiramatsu , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , Network Development , Linux Kernel Mailing List From: Arend Van Spriel Message-ID: <15e43df4-b8cc-8612-472e-80634cf27cac@broadcom.com> (sfid-20160815_234433_193884_2F07EBA5) Date: Mon, 15 Aug 2016 23:44:05 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 15-8-2016 13:52, Rafał Miłecki wrote: > On 15 August 2016 at 12:57, Kalle Valo wrote: >> Rafał Miłecki writes: >> >>>> Signed-off-by: Masami Hiramatsu >>> >>> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent fw request") >>> Acked-by: Rafał Miłecki >>> >>> Kalle: I'm acking this as bugfix for 4.8 release. >> >> Ok. I'll wait few days for more comments before I apply this. > > Sure. > > >> (I assume you are talking only about patch 1) > > Yes, I'll leave mutex vs. spinlock to the experts :) Don't know who the experts are. Surely not me :-p I made an uneducated design decision using a mutex for this. The reasoning for using a regular spinlock make sense. So I will go and ack that patch. Regards, Arend