Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:34645 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011AbcHSCbW (ORCPT ); Thu, 18 Aug 2016 22:31:22 -0400 Received: by mail-pa0-f52.google.com with SMTP id fi15so11284140pac.1 for ; Thu, 18 Aug 2016 19:31:21 -0700 (PDT) Subject: Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1471529868-13669-1-git-send-email-javier@osg.samsung.com> Cc: Amitkumar Karwar , Kalle Valo , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Nishant Sarmukadam From: Arend van Spriel Message-ID: <10fb1110-4c0b-00a2-522c-7011ca397b8c@broadcom.com> (sfid-20160819_043142_359674_0432B285) Date: Thu, 18 Aug 2016 21:14:35 +0200 MIME-Version: 1.0 In-Reply-To: <1471529868-13669-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 18-08-16 16:17, Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may still function without this wake interrupt. Regards, Arend > Signed-off-by: Javier Martinez Canillas > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c > index d3e1561ca075..00727936ad6e 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sdio.c > +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c > @@ -125,6 +125,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) > dev_err(dev, > "Failed to request irq_wifi %d (%d)\n", > cfg->irq_wifi, ret); > + return ret; > } > disable_irq(cfg->irq_wifi); > } >