Return-path: Received: from mail-oi0-f68.google.com ([209.85.218.68]:33608 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbcH2QkK (ORCPT ); Mon, 29 Aug 2016 12:40:10 -0400 MIME-Version: 1.0 In-Reply-To: References: <1472474375-29910-1-git-send-email-baoyou.xie@linaro.org> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 29 Aug 2016 18:39:25 +0200 Message-ID: (sfid-20160829_184038_153008_04B92361) Subject: Re: [PATCH v4] brcmfmac: add missing header dependencies To: Baoyou Xie Cc: Arend Van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , Network Development , Linux Kernel Mailing List , Arnd Bergmann , xie.baoyou@zte.com.cn Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 29 August 2016 at 17:42, Baoyou Xie wrote: > On 29 August 2016 at 23:31, Rafa=C5=82 Mi=C5=82ecki wr= ote: >> >> On 29 August 2016 at 14:39, Baoyou Xie wrote: >> > We get 1 warning when build kernel with W=3D1: >> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: >> > warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes= ] >> >> building? I'm not native English, but I think so. >> >> >> > In fact, this function is declared in brcmfmac/debug.h, so this patch >> > add missing header dependencies. >> >> adds >> >> >> > Signed-off-by: Baoyou Xie >> > Acked-by: Arnd Bergmann >> >> Please don't resend patches just to add tags like that. This only >> increases a noise and patchwork handles this just fine, see: >> https://patchwork.kernel.org/patch/9303285/ >> https://patchwork.kernel.org/patch/9303285/mbox/ > > > it modifies a typo biuld/build. Please send your replies to all, not privately. OK, so you should also include a changelog in the comments part of diff, e.= g.: V4: Fix typo in "biuld"