Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:57479 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729AbcHBLTQ convert rfc822-to-8bit (ORCPT ); Tue, 2 Aug 2016 07:19:16 -0400 From: "Valo, Kalle" To: "michal.kazior@tieto.com" CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , "nbd@nbd.name" Subject: Re: [RFC] ath10k: silence firmware file probing warnings Date: Tue, 2 Aug 2016 11:18:15 +0000 Message-ID: <87ziov772h.fsf@kamboji.qca.qualcomm.com> (sfid-20160802_202639_164427_C1C0D126) References: <1468933237-5226-1-git-send-email-michal.kazior@tieto.com> In-Reply-To: <1468933237-5226-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 19 Jul 2016 15:00:37 +0200") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > Firmware files are versioned to prevent older > driver instances to load unsupported firmware > blobs. This is reflected with a fallback logic > which attempts to load several firmware files. > > This however produced a lot of unnecessary > warnings sometimes confusing users and leading > them to rename firmware files making things even > more confusing. > > Hence use request_firmware_direct() which does not > produce extra warnings. This shouldn't really > break anything because most modern systems don't > rely on udev/hotplug helpers to load firmware > files anymore. > > Signed-off-by: Michal Kazior Nice. These "firmware not found" messages have been confusing ath10k users for ages and should be properly fixed. I hope we find a solution. But I talked with Felix about this and he made a good point about board and calibration files. Calibration files might be created runtime, for example retrieved from NAND etc, and this might break the use case when ath10k is statically linked to kernel. Is the combination used in real life and should we care, that I do not know, but I'm worried of possible regressions. I guess LEDE/openwrt always loads ath10k as a module and after the calibration file is created? -- Kalle Valo