Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:40051 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbcHBIcN (ORCPT ); Tue, 2 Aug 2016 04:32:13 -0400 Message-ID: <1470124193.2665.13.camel@sipsolutions.net> (sfid-20160802_103241_348939_4F1575D6) Subject: Re: [PATCH v2] mac80211: rx: frames received out of order From: Johannes Berg To: Yaniv Machani , linux-kernel@vger.kernel.org Cc: Meirav Kama , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Tue, 02 Aug 2016 09:49:53 +0200 In-Reply-To: <20160713115758.25395-1-yanivma@ti.com> (sfid-20160713_135411_110427_3A917D6E) References: <20160713115758.25395-1-yanivma@ti.com> (sfid-20160713_135411_110427_3A917D6E) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2016-07-13 at 14:57 +0300, Yaniv Machani wrote: > From: Meirav Kama > > Upon forwarding frames from Rx to Tx in mesh, driver clones the skb. > It zeros the tx_info and doesn't set hw_queue correctly. It then > enqueues > the frame in queue 0 (VOICE) instead of the correct queue. > Upon re-queue of this frame, driver inserts it to the correct queue > (e.g. BE). > After that, driver dequeue frames from 2 different queues and sends > them out of order. > To fix this, driver will set the tx_info->hw_queue to the correct > queue when cloning the skb. > Makes sense, but the subject is a bit misleading - can you come up with a better one? johannes