Return-path: Received: from mail-it0-f49.google.com ([209.85.214.49]:37982 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933022AbcIHPbh (ORCPT ); Thu, 8 Sep 2016 11:31:37 -0400 Received: by mail-it0-f49.google.com with SMTP id c198so87614845ith.1 for ; Thu, 08 Sep 2016 08:31:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87k2emsi22.fsf@kamboji.qca.qualcomm.com> References: <1473200312-22438-1-git-send-email-bjorn.andersson@linaro.org> <1473200312-22438-2-git-send-email-bjorn.andersson@linaro.org> <87k2emsi22.fsf@kamboji.qca.qualcomm.com> From: Bjorn Andersson Date: Thu, 8 Sep 2016 08:31:36 -0700 Message-ID: (sfid-20160908_173204_607461_7A62E276) Subject: Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client To: Kalle Valo Cc: Eugene Krasnikov , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev , lkml , Andy Gross , linux-arm-msm Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote: > Bjorn Andersson writes: > >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. This patch makes this >> transition, now that we have the necessary frameworks available. >> >> Signed-off-by: Bjorn Andersson >> --- >> >> Changes since v3: >> - Made msg_header const in wcn36xx_smd_rsp_process() >> >> Changes since v2: >> - Correct the call to the new ieee80211_scan_completed() >> >> drivers/net/wireless/ath/wcn36xx/dxe.c | 16 +++--- >> drivers/net/wireless/ath/wcn36xx/main.c | 79 ++++++++++++++++++++---------- >> drivers/net/wireless/ath/wcn36xx/smd.c | 31 +++++------- >> drivers/net/wireless/ath/wcn36xx/smd.h | 5 ++ >> drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 21 +++----- >> 5 files changed, 86 insertions(+), 66 deletions(-) > > This doesn't compile for me: > I thought I mentioned this in the mail, sorry for missing that. There is a patch for this issue in linux-next already [1] which is part of [2], which was part of the pull request to arm-soc for inclusion in v4.9. [1] https://patchwork.kernel.org/patch/9272457/ [2] https://git.kernel.org/cgit/linux/kernel/git/agross/linux.git/tag/?h=qcom-drivers-for-4.9 Regards, Bjorn