Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755565AbcILLY7 (ORCPT ); Mon, 12 Sep 2016 07:24:59 -0400 Date: Mon, 12 Sep 2016 13:24:10 +0200 From: Stanislaw Gruszka To: Julia Lawall Cc: joe@perches.com, kernel-janitors@vger.kernel.org, Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/26] iwlegacy: constify local structures Message-ID: <20160912112409.GA2670@redhat.com> (sfid-20160912_132522_115285_9407D588) References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-9-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1473599168-30561-9-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Sep 11, 2016 at 03:05:50PM +0200, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka