Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43094 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932674AbcI0Pr0 (ORCPT ); Tue, 27 Sep 2016 11:47:26 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: brcmfmac: replace WARNING on timeout with a simple error message From: Kalle Valo In-Reply-To: <20160927101224.3534-1-zajec5@gmail.com> References: <20160927101224.3534-1-zajec5@gmail.com> To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Message-Id: <20160927154725.609A161405@smtp.codeaurora.org> (sfid-20160927_174807_609009_B1F5BFCC) Date: Tue, 27 Sep 2016 15:47:25 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Rafał Miłecki wrote: > From: Rafał Miłecki > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover and > for that time it doesn't process packets. > > It's still useful to have a message on time out as it may indicate some > firmware problem and incorrect key update. Raising a WARNING however > wasn't really that necessary, it doesn't point to any driver bug anymore > and backtrace wasn't much useful. > > Signed-off-by: Rafał Miłecki > Acked-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. 2f0e56fa37cc brcmfmac: replace WARNING on timeout with a simple error message -- https://patchwork.kernel.org/patch/9351657/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches